feat: support Sourcegraph Amp cli #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugodutka
reviewed
Aug 6, 2025
…/agentapi into Sourcegraph-Amp-Module-Support
|
@Harsh9485 one of the tests is failing - not sure if you have access to CI results here. You should be able to see it locally when you run |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for Sourcegraph Amp CLI as a new agent type in the AgentAPI system. It extends the existing framework to handle Amp agent messages alongside other supported agents like Claude, Goose, Aider, Gemini, and Codex.
Key changes include:
- Addition of AgentTypeAmp constant and integration into the agent type system
- Test data for validating Amp message formatting behavior
- Documentation update to include Sourcegraph Amp in the list of supported agents
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/msgfmt/msgfmt.go | Adds AgentTypeAmp constant and routing to generic message formatting |
| cmd/server/server.go | Integrates AgentTypeAmp into server agent type definitions and validation |
| lib/msgfmt/msgfmt_test.go | Includes AgentTypeAmp in the test suite for message formatting |
| cmd/server/server_test.go | Adds test case for parsing "amp" agent type |
| lib/msgfmt/testdata/format/amp/* | Test data files for validating Amp message formatting scenarios |
| README.md | Updates documentation to include Sourcegraph Amp in supported agents list |
hugodutka
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hugodutka, let me know if you need any changes. I’m not very familiar with the agentAPI code, so if I messed something up, please let me know.